Skip to content

Add Clan Wars Free-For-All (Safe & Dangerous) portals #949

Merged
GregHib merged 20 commits intoGregHib:mainfrom
HarleyGilpin:main
Apr 14, 2026
Merged

Add Clan Wars Free-For-All (Safe & Dangerous) portals #949
GregHib merged 20 commits intoGregHib:mainfrom
HarleyGilpin:main

Conversation

@HarleyGilpin
Copy link
Copy Markdown
Contributor

@HarleyGilpin HarleyGilpin commented Apr 13, 2026

Add Clan Wars Free-For-All (Safe & Dangerous) portals

Summary

  • Implement entry and exit portals for both FFA Safe and FFA Dangerous arenas
  • Both portals share the same warning interface (id 793), with varbit 5279 selecting which text the client displays
  • Warning dismiss preferences are stored independently per portal and integrate with the Doomsayer system
  • Safe arena keeps items on death, dangerous arena drops items on death
  • PvP is enabled only inside the fighting areas, with the Clan Wars overlay shown across both arenas
  • Challenge portal (purple) shows an "under construction" message
  • Tested in-game end-to-end

Bug fixes & Improvements

  • Dragon claws special attack.
  • Dark bow can now shoot dragon arrows.
  • Fixed game crash in the Fight Caves minigame.
  • Fixed a bug with character account creation
  • Bank tab creation via drag-and-drop was silently ignored because the interfaceSwap handler only matched on fromId, causing the generic inventory swap handler to intercept the event instead.
  • Collapsing a tab with more than two rows of items crashed the client because shiftToFreeIndex generated O(N*M) intermediate inventory updates in a single packet. Replaced with a single-pass bulk rearrangement.
Screencast_20260412_143216.webm

Comment thread game/src/main/kotlin/content/minigame/clan_wars/ClanWarsFreeForAll.kt Outdated
Comment thread game/src/main/kotlin/content/minigame/clan_wars/ClanWarsFreeForAll.kt Outdated
Comment thread game/src/main/kotlin/content/skill/melee/weapon/special/DragonClaws.kt Outdated
Comment thread game/src/main/kotlin/content/skill/melee/weapon/special/DragonClaws.kt Outdated
@HarleyGilpin
Copy link
Copy Markdown
Contributor Author

@GregHib - I have addressed your code review notes. I also added a bug fix that caused game crashes when collapsing tabs and fixed bank tab creation that wasn't in the original PR: 78ff78b

…walkable one, so a single blocked direction no longer traps the NPC.
@GregHib GregHib merged commit 7e54451 into GregHib:main Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants